On 08/26/2010 11:27 AM, Ralf Wildenhues wrote:
>
>>    m4sh: assume ${a:-b} support
>
> This one contains merge conflict markers, so cannot have been tested
> in this spelling.  The tests in this one assume that unset works (I'm
> not judging that, just stating that it's the case).

Thanks; I've fixed those merge markers, and redone my testing.

We've already proved that unset works for all shells that have
functions, except for the corner case of using old bash to unset an
undefined variable.  If we can prove a variable is already set, using
'unset' is fine; if we can't, then using AS_UNSET is required.

>
> If you (still) need somebody to test IRIX, OSF, Solaris 2.6, AIX, please
> ping me.  I definitely would feel a bit less worried if these changes
> were thoroughly tested before the next release.

I've gone ahead and pushed the remaining patch from this series, if
you'd like to start widening the test exposure.

--
Eric Blake   eblake@redh...    +1-801-349-2682
Libvirt virtualization library http://libvirt.org