opensubscriber
   Find in this group all groups
 
Unknown more information…

b : bugs@subversion.tigris.org 3 September 2008 • 5:27AM -0400

[Issue 3278] Merges involving filenames with spaces are problematic
by mattinger

REPLY TO AUTHOR
 
REPLY TO GROUP




http://subversion.tigris.org/issues/show_bug.cgi?id=3278



User mattinger changed the following:

                What    |Old value                 |New value
================================================================================
            Subcomponent|libsvn_ra_neon            |svnmerge
--------------------------------------------------------------------------------




------- Additional comments from mattinger@tigr... Tue Sep  2 14:27:20 -0700 2008 -------
The simpler fix is as follows:

There's a call to svn_client__ensure_ra_session_url which generates the error
when called with a path which
includes spaces.  This should be modified so that the "mergeinfo_url" variable
is constructed using a call to
the "svn_path_uri_encode" function:

at line 3364 of merge.c
---------------------------------------
const char *mergeinfo_url =
  svn_path_join(web->source_root_url,
      /* Skip leading '/' or join won't work. */
       svn_path_uri_encode(++(merge_src_child_path->data), pool),
       pool);


If you want an actual patch file, I can get the code out of the repository, but
it's a pretty small change anyway.



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@subv...
For additional commands, e-mail: issues-help@subv...

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.