It makes sense for your explanation.

It didn't work for HP's NonStop (Tandem) platform, which is unfortunately
the one I am working on, so I made that quick fix.

It's up to you guys to decide what's the best. From what you are saying,
it seems to me that API caller, such as Ant for my case, needs to make a
fix.


Thanks!

Bing





"Daniel F. Savarese" <dfs@sava...>
07/08/2005 01:08 AM
Please respond to "Jakarta Commons Developers List"

        To:     commons-dev@jaka...
        cc:
        Subject:        Re: [net] Found and fixed a bug in FTPClient class
in Commons Net project.



In message
<OF70B962D2.CAE4E06C-ON88257037.00544E54-88257037.00547B02@idx....>,
Bing_Wu@idx.... writes:
>I downloaded the source code and found the problem. It's in getSystemName

>method of FTPClient class in Commons Net project. The reason is that for
>some system, such as HP's NonStop (Tandem) platform, "SYST" command is
not
>understood, so __systemName will be null thus causing the error above.

The proper place to handle this would be in the caller to getSystemName,
otherwise you will never be able to know that the system name is
unknown.  The documentaton for getSystemName() says:
  * @return The system type name obtained from the server.  null if the
  *       information could not be obtained.

In other words, it is intended to return null.  It is up to the caller
to decide what to do with the information.  If there's a need for a
change,
I would suggest making it higher up in the call chain.  Steve would
know best if there's any need.  My guess is that the intent is for
API users to catch that ParserInitializationException and select a
default parser according their needs instead of having Commons Net
make the decision for them.

daniel


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jaka...
For additional commands, e-mail: commons-dev-help@jaka...




-----------------------------------------------
IMPORTANT NOTIFICATION
-----------------------------------------------
The contents of this e-mail and its attachments are confidential and may be privileged.  If you are not the intended recipient of this e-mail, please notify IDX immediately (by return e-mail to either the sender or security@idx....), destroy all copies of this message along with any attachments and do not disclose, copy and/or distribute the contents.  The views expressed in this message are those of the author and not necessarily those of IDX.  In the absence of a prior written agreement with you authorizing commitments of IDX via e-mail, the above message shall not bind IDX, unless from a duly authorized officer of the company in a context indicating an intention to bind the company.

This e-mail and its attachments are protected by copyright and other laws. (c) IDX Systems Corporation 2005.  All rights reserved.  IDX is a registered trademark of IDX Investment Corporation.