cmadams@hiwa... (Chris Adams) wrote:

>Take a look at my old SRPM (Cricket 1.0.3 for RHEL 3) and see what you
>think:

Thanks, I'll take a look at it as soon as I get my devel box set up.


>It isn't used anywhere.  There's only one reference to gLongDSName and it
>uses $Common::global::gLongDSName.

Ah, good spot!


>It looks like "our" may be better; at the time I did that, I had zero
>experience using "our" (I think I was still running on a perl 5.005
>system, where "our" does not exist).  That does work and is cleaner, but
>it does change the minimum version of perl to 5.6.0.  Is that okay?

Hmm. I'm not particularly worried about that; RHEL3 has Perl
5.8.0, which I'd guess to suggest that every major distro will
have had 5.6.0+ for at least their last 2-3 major releases.
5.6.0 was released in 2000, so it's been out for 8 years now.

I'd suggest you check in your patches, including using 'our' for
this patch, and we'll whip up some kind of workaround iff
someone starts yelling about it.


In fact, I'd be inclined to require Perl 5.8.0 (for the Unicode
support) in the next major rev release of Cricket (but not,
perhaps, in the postulated minor bugfix release). Supporting
older versions of Perl is nice, but not at any expense; and I'd
rather start from cleaner code and make workarounds as needed,
than keep old cruft that may or may not break a pathological
installation somewhere if changed.

--
Everytime I write a rhyme these people thinks its a crime
I tell `em what's on my mind. I guess I'm a CRIMINAL!
I don't gotta say a word I just flip `em the bird and keep goin,
I don't take shit from no one. I'm a CRIMINAL!


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
cricket-developers mailing list
cricket-developers@list...
https://lists.sourceforge.net/lists/listinfo/cricket-developers