opensubscriber
   Find in this group all groups
 
Unknown more information…

d : dev@shindig.apache.org 12 February 2012 • 9:46AM -0500

Review Request: Array iteration cleanup in the actions_container.js file
by Henry Saputra

REPLY TO AUTHOR
 
REPLY TO GROUP





-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3873/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Some of the iterations in the actions_container.js file are using "in" operator without calling hasOwnProperty to make sure its not going up to prototype chain (http://yuiblog.com/blog/2006/09/26/for-in-intrigue/). It causes trouble when executing in some browsers like FF5.

Small cleanup for actual array to just simply used for-loop with index.


Diffs
-----

  trunk/features/src/main/javascript/features/actions/actions_container.js 1243090

Diff: https://reviews.apache.org/r/3873/diff


Testing
-------

Pass JS unit tests and manual test with common container and action container.


Thanks,

Henry


Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.