> On 2012-03-15 00:21:21, Ryan Baxter wrote:
> >
>
> Ryan Baxter wrote:
>     Oops meant to add some context here before I published :)
>    
>     I am OK with these changes, Henry has asked the obvious changes.  I am not really that familiar with some of the implications of these changes, so not sure how useful my review is.  Just as a cleanup, I found some trailing whitespaces in the changes.

Thanks Ryan.
For removal of those whitespaces, would you prefer me to provide a new patch or is that something (automatically) can be taken care of by whom would commit the patch?


- Ate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------


On 2012-02-14 00:03:44, Ate Douma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3887/
> -----------------------------------------------------------
>
> (Updated 2012-02-14 00:03:44)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@doum...%3E
>
> The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
>
>
> This addresses bug SHINDIG-1689.
>     https://issues.apache.org/jira/browse/SHINDIG-1689
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
>   http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
>   http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
>
> Diff: https://reviews.apache.org/r/3887/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ate
>
>