-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4268/
-----------------------------------------------------------

(Updated 2012-05-22 13:55:37.337786)


Review request for shindig, Henry Saputra, Ryan Baxter, and Stanton Sievers.


Changes
-------

\\w already includes "_" so removed...
Anyone tired of revisions yet?


Summary
-------

A base implementation for OpenSocial Groups.  Provides groups to the osapi javascript namespace with an implementation link for get() in GroupService.


This addresses bug SHINDIG-1780.
    https://issues.apache.org/jira/browse/SHINDIG-1780


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SocialHelloWorld.xml 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/content/sampledata/canonicaldb.json 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/ActivityServiceDb.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/AppDataServiceDb.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiDatabaseBootstrap.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/resources/sampledata/canonicaldb.json 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/GroupImpl.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Group.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/LocalId.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ObjectId.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/DomainNameTest.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GlobalIdTest.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java 1341444
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/LocalIdTest.java PRE-CREATION
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/ObjectIdTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/4268/diff


Testing
-------

Used the common container with a gadget to call osapi.groups.get()

--

Created and updated unit tests
All tests pass


Thanks,

Mike