[ https://issues.apache.org/jira/browse/VELOCITY-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627442#action_12627442 ]

Adrian Tarau commented on VELOCITY-467:
---------------------------------------

Because your logging level in production is WARN or INFO. Except if you are investigating something(like getting an exception and you want to see more details) you will not have DEBUG level set in production. In this case if something went wrong you will not know(we assume you are looking at the logs for errors or have some sort of notification when something is logged with error level).

I'm fine using DEBUG in general, since you are interested only at development time to see what went wrong, but in production you will not have DEBUG so at some extent things that are really wrong(passing wrong type to #foreach) should be logged as errors. In this case a custom Uberspect will the "problem",  but still...

Just my 2 cents :)


> Throw more exceptions and log less errors
> -----------------------------------------
>
>                 Key: VELOCITY-467
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-467
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 1.5 beta1
>            Reporter: Will Glass-Husain
>            Priority: Minor
>             Fix For: 1.6
>
>
> Now that Velocity application exceptions are based on RuntimeException, we have more opportunity to use exceptions to signal application level problems.  I'm particularly concerned about initialization problems that are logged and may be missed.  We need to review all logged error messages and see if it would be more appropriate to throw an exception instead.  Some of these places we may need to leave as is for backwards compatibility reasons.  (e.g. macro in the global macro library doesn't parse properly).
> Llewellyn Falco made a good case for this on the dev list recently:
> http://www.mail-archive.com/velocity-dev@jaka.../msg15067.html
> #####
> I still would like to put in my vote that sending error's to the log is an incredibly BAD idea.
> If something is not working, it should be LOUDLY shown as an exception.
> If it is working I don't really need a log.
> The (velocity) log should be there for velocity developers (those programming the actual velocity code) not users.
> I don't ever care to see tomcat's log, I care to see the things I log while in tomcat.
> Most of all, many many many people do not check the log at all, let alone frequently.
> ####

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velo...
For additional commands, e-mail: dev-help@velo...