Adrian Tarau commented on VELOCITY-467:
I would say it is wrong, but how much? I think it depends on application type.
Which scenario is better? :
1. Just log the error(so the developers will know) and some small part of the web page(we are still building an web application) will be missing but the user could still use the page(assuming the missing part is not critical)
2. Throw an exception, the user will get an "Sorry we have a problem, came back later".
I think(in general in software development) it is preferable to fail (fast) instead of giving partial results, but this could not work for everybody. Fail or error it is for sure better (my opinion) than debug for handling wrong type passed to #foreach.
Yes, something like that would be great. Thanks.
> Throw more exceptions and log less errors
> Key: VELOCITY-467
> URL: https://issues.apache.org/jira/browse/VELOCITY-467 > Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.5 beta1
> Reporter: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
> Now that Velocity application exceptions are based on RuntimeException, we have more opportunity to use exceptions to signal application level problems. I'm particularly concerned about initialization problems that are logged and may be missed. We need to review all logged error messages and see if it would be more appropriate to throw an exception instead. Some of these places we may need to leave as is for backwards compatibility reasons. (e.g. macro in the global macro library doesn't parse properly).
> Llewellyn Falco made a good case for this on the dev list recently:
> I still would like to put in my vote that sending error's to the log is an incredibly BAD idea.
> If something is not working, it should be LOUDLY shown as an exception.
> If it is working I don't really need a log.
> The (velocity) log should be there for velocity developers (those programming the actual velocity code) not users.
> I don't ever care to see tomcat's log, I care to see the things I log while in tomcat.
> Most of all, many many many people do not check the log at all, let alone frequently.
This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.