opensubscriber
   Find in this group all groups
 
Unknown more information…

d : dri-devel@lists.freedesktop.org 29 June 2012 • 6:46PM -0400

Re: [PATCH] staging: drm/omap: add rotation properties
by Tomi Valkeinen

REPLY TO AUTHOR
 
REPLY TO GROUP




On Wed, 2012-06-27 at 09:06 -0500, Rob Clark wrote:
> From: Rob Clark <rob@ti.c...>
>
> Use tiled buffers for rotated/reflected scanout, with CRTC and plane
> properties as the interface for userspace to configure rotation.
>
> Signed-off-by: Rob Clark <rob@ti.c...>

> +/* this should probably be in drm-core to standardize amongst drivers */
> +#define DRM_ROTATE_0 0
> +#define DRM_ROTATE_90 1
> +#define DRM_ROTATE_180 2
> +#define DRM_ROTATE_270 3
> +#define DRM_REFLECT_X 4
> +#define DRM_REFLECT_Y 5

Are both reflect X and Y needed? You can get all the possible
orientations with just one of the reflects.

And I think the word "mirror" represents nicely what the reflect does,
i.e. if you look at the mirror, the image you see is flipped
horizontally.

Tomi


Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.