On Mon, 05 Dec 2011 14:23:55 -0800, Eric Anholt <eric@anho...> wrote:
> On Mon,  5 Dec 2011 02:31:58 -0800 (PST), ickle@kemp... (Chris Wilson) wrote:
> >  configure.ac             |    2 +-
> >  intel/intel_bufmgr_gem.c |   27 +++++++++++++++++++++------
> >  2 files changed, 22 insertions(+), 7 deletions(-)
> >
> > New commits:
> > commit e73161a02b604742e3da3bca8f13cff81276de43
> > Author: Chris Wilson <chris@chri...>
> > Date:   Mon Dec 5 10:30:52 2011 +0000
> >
> >     configure: Bump version to 2.4.28
> >    
> >     So that we can pull a couple of Intel bug fixes into xf86-video-intel.
> >    
> >     Signed-off-by: Chris Wilson <chris@chri...>
>
> Performance before:
> [  0]       gl            firefox-talos-gfx   17.866   17.915   0.14%    4/4
> after:
> [  0]       gl            firefox-talos-gfx   22.173   22.251   0.20%    4/4
>
> There's a pretty obvious opportunity to keep the performance win of the
> userspace caching that you've broken here, but you gave none of us a
> chance to review it before you pushed the patch *and shipped a release
> with it*.  This is not acceptable.  Please revert and bump the release,
> and fix it correctly.

No, what was unacceptable was a vma leak impacting a critical system
application, and for the library API to be broken by design. The onus is
to improve performance without regressing system stability, not the
other way around.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre

------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@list...
https://lists.sourceforge.net/lists/listinfo/dri-devel