Andriy Gapon <avg@Free...> wrote:

> It seems that the $subj is missing :-)
> In my environment that causes many functions to not have fbt return probe,
> because function body decoding fails before 'ret' is found.
>
> Here is my attempt at fixing the problem:
> http://people.freebsd.org/~avg/fbt-nop.patch
> Reviews and suggestions are welcome.

The patch seems to reduce the number of missing
fbt return probes by about 50% for me.

Without the patch:

fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c entry
23395
fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c return
16739

With the patch (and updated kernel sources):

fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c entry
23409
fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c return
19879

Thanks
Fabian