[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753373#action_12753373 ]

Robert Muir commented on LUCENE-1887:
-------------------------------------

Luis, yeah, the difference is your patch has the deprecated methods.

in my patch there are no deprecated methods, it uses Object[] instead of varargs.
but these are compatible to jdk1.5: http://java.sun.com/j2se/1.5.0/docs/guide/language/varargs.html
so you can change it to ... (varargs) and it will be backwards compatible, without any deprecation.
then at your leisure, once on jdk1.5, you can remove the new Object[] {}, it will be autoboxed.


> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
>                 Key: LUCENE-1887
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1887
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>            Reporter: Hoss Man
>            Priority: Minor
>         Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@luce...
For additional commands, e-mail: java-dev-help@luce...