opensubscriber
   Find in this group all groups
 
Unknown more information…

l : linux-ide@vger.kernel.org 12 April 2008 • 12:35PM -0400

Re: [PATCH #upstream 1/2] libata: kill dead code paths in reset path
by Jeff Garzik

REPLY TO AUTHOR
 
REPLY TO GROUP




Tejun Heo wrote:
> Some code paths which had been made obsolete by recent reset
> simplification were still around.  Kill them.
>
> * ata_eh_reset() checked for ATA_DEV_UNKNOWN to determine
>  classification failure.  This is no longer applicable.
>
> * ata_do_reset() should convert ATA_DEV_UNKNOWN to ATA_DEV_NONE
>  regardless of reset result (e.g. -EAGAIN).
>
> * LLDs don't need to convert ATA_DEV_UNKNOWN to ATA_DEV_NONE.
>
> Signed-off-by: Tejun Heo <htejun@gmai...>
> ---
> drivers/ata/libata-eh.c     |   19 +------------------
> drivers/ata/sata_inic162x.c |    2 --
> drivers/ata/sata_sil24.c    |    3 ---
> 3 files changed, 1 insertion(+), 23 deletions(-)

applied 1-2

Mark, let us know how we stand WRT sata_mv PMP needs, this should help.


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.