opensubscriber
   Find in this group all groups
 
Unknown more information…

m : mythtv-dev@mythtv.org 15 April 2006 • 2:53PM -0400

[mythtv] Patch proposal for better logging of ivtv select timeouts
by f-myth-users

REPLY TO AUTHOR
 
REPLY TO GROUP




    > Date: Thu, 13 Apr 2006 10:52:33 -0400
    > From: Daniel Kristjansson <danielk@cuym...>

    > Nope, but if you change the cerr redirects and printfs to the proper
    > verbose macros that would be appreciated and accepted. Assign the ticket
    > to 'danielk' for the quickest response.

Some questions:

    >     cerr << "Audiorate(L1): " << value << " is invalid\n";
    > becomes
    >     VERBOSE(VB_IMPORTANT, LOC_ERR +
    >             QString("Audiorate(L1 %1) is invalid").arg(value);

Did you mean LOC here and not LOC_ERR?  Or perhaps both your examples
are true errors but elsewhere in that file are some non-errors that
will want to use LOC?  (This may become obvious when I look through
the rest of the logging there.)

    >     printf("select timeout - ivtv driver has stopped responding\n");
    > becomes
    >     VERBOSE(VB_IMPORTANT, LOC_ERR + "select timeout -- "
    >             "ivtv driver has stopped responding" + ENO);

    > where LOC and LOC_ERR are:
    > #define LOC QString("IVTVRec(%1): ").arg(videodevice)
    > #define LOC QString("IVTVRec(%1) Error: ").arg(videodevice)

I presume you meant the latter macro to be

#define LOC_ERR QString("IVTVRec(%1) Error: ").arg(videodevice)
_______________________________________________
mythtv-dev mailing list
mythtv-dev@myth...
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.