opensubscriber
   Find in this group all groups
 
Unknown more information…

p : pspp-dev@gnu.org 17 July 2012 • 2:45PM -0400

[PATCH 3/5] var-type-dialog: Use G_TYPE_INT to store an int.
by Ben Pfaff

REPLY TO AUTHOR
 
REPLY TO GROUP




It seems more straightforward to store an int by value than by
pointer.
---
src/ui/gui/var-type-dialog.c |    9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/ui/gui/var-type-dialog.c b/src/ui/gui/var-type-dialog.c
index aa46ca4..4ed27f0 100644
--- a/src/ui/gui/var-type-dialog.c
+++ b/src/ui/gui/var-type-dialog.c
@@ -314,7 +314,7 @@ set_format_type_from_treeview (GtkTreeView *treeview, gpointer data)
   gtk_tree_model_get_value (model, &iter, 1, &the_value);

   dialog->fmt_l = custom_format;
-  dialog->fmt_l.type = *(int*) g_value_get_pointer (&the_value);
+  dialog->fmt_l.type = g_value_get_int (&the_value);

   g_value_unset (&the_value);
}
@@ -500,8 +500,7 @@ var_type_dialog_create (GtkWindow *toplevel)
       column);


-  list_store = gtk_list_store_new (2, G_TYPE_STRING,
- G_TYPE_POINTER);
+  list_store = gtk_list_store_new (2, G_TYPE_STRING, G_TYPE_INT);

   for ( i = 0 ; i < 5 ; ++i )
     {
@@ -509,7 +508,7 @@ var_type_dialog_create (GtkWindow *toplevel)
       gtk_list_store_append (list_store, &iter);
       gtk_list_store_set (list_store, &iter,
                           0, fmt_name (cc_fmts[i]),
-   1, &cc_format[i],
+   1, cc_format[i],
  -1);
     }

@@ -640,7 +639,7 @@ select_treeview_from_format_type (GtkTreeView *treeview,

       gtk_tree_model_get_value (model, &iter, 1, &value);

-      spec = * ((int *) g_value_get_pointer (&value));
+      spec = g_value_get_int (&value);

       g_value_unset (&value);

--
1.7.2.5


_______________________________________________
pspp-dev mailing list
pspp-dev@gnu....
https://lists.gnu.org/mailman/listinfo/pspp-dev

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

opensubscriber is not affiliated with the authors of this message nor responsible for its content.